Skip to content
  • Hanna Czenczek's avatar
    cc63f6f6
    util/iov: Remove qemu_iovec_init_extended() · cc63f6f6
    Hanna Czenczek authored
    
    
    bdrv_pad_request() was the main user of qemu_iovec_init_extended().
    HEAD^ has removed that use, so we can remove qemu_iovec_init_extended()
    now.
    
    The only remaining user is qemu_iovec_init_slice(), which can easily
    inline the small part it really needs.
    
    Note that qemu_iovec_init_extended() offered a memcpy() optimization to
    initialize the new I/O vector.  qemu_iovec_concat_iov(), which is used
    to replace its functionality, does not, but calls qemu_iovec_add() for
    every single element.  If we decide this optimization was important, we
    will need to re-implement it in qemu_iovec_concat_iov(), which might
    also benefit its pre-existing users.
    
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
    Signed-off-by: default avatarHanna Czenczek <hreitz@redhat.com>
    Message-Id: <20230411173418.19549-4-hreitz@redhat.com>
    cc63f6f6
    util/iov: Remove qemu_iovec_init_extended()
    Hanna Czenczek authored
    
    
    bdrv_pad_request() was the main user of qemu_iovec_init_extended().
    HEAD^ has removed that use, so we can remove qemu_iovec_init_extended()
    now.
    
    The only remaining user is qemu_iovec_init_slice(), which can easily
    inline the small part it really needs.
    
    Note that qemu_iovec_init_extended() offered a memcpy() optimization to
    initialize the new I/O vector.  qemu_iovec_concat_iov(), which is used
    to replace its functionality, does not, but calls qemu_iovec_add() for
    every single element.  If we decide this optimization was important, we
    will need to re-implement it in qemu_iovec_concat_iov(), which might
    also benefit its pre-existing users.
    
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
    Signed-off-by: default avatarHanna Czenczek <hreitz@redhat.com>
    Message-Id: <20230411173418.19549-4-hreitz@redhat.com>
Loading