Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    8b0c5d76
    block/io: support int64_t bytes in bdrv_aligned_preadv() · 8b0c5d76
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, prepare bdrv_aligned_preadv() now.
    
    Make the bytes variable in bdrv_padding_rmw_read() int64_t, as it is
    only used for pass-through to bdrv_aligned_preadv().
    
    All bdrv_aligned_preadv() callers are safe as type is widening. Let's
    look inside:
    
     - add a new-style assertion that request is good.
     - callees bdrv_is_allocated(), bdrv_co_do_copy_on_readv() supports
       int64_t bytes
     - conversion of bytes_remaining is OK, as we never have requests
       overflowing BDRV_MAX_LENGTH
     - looping through bytes_remaining is ok, num is updated to int64_t
       - for bdrv_driver_preadv we have same limit of max_transfer
       - qemu_iovec_memset is OK, as bytes+qiov_offset should not overflow
         qiov->size anyway (thanks to bdrv_check_qiov_request())
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-14-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    [eblake: grammar tweak]
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    8b0c5d76
    block/io: support int64_t bytes in bdrv_aligned_preadv()
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, prepare bdrv_aligned_preadv() now.
    
    Make the bytes variable in bdrv_padding_rmw_read() int64_t, as it is
    only used for pass-through to bdrv_aligned_preadv().
    
    All bdrv_aligned_preadv() callers are safe as type is widening. Let's
    look inside:
    
     - add a new-style assertion that request is good.
     - callees bdrv_is_allocated(), bdrv_co_do_copy_on_readv() supports
       int64_t bytes
     - conversion of bytes_remaining is OK, as we never have requests
       overflowing BDRV_MAX_LENGTH
     - looping through bytes_remaining is ok, num is updated to int64_t
       - for bdrv_driver_preadv we have same limit of max_transfer
       - qemu_iovec_memset is OK, as bytes+qiov_offset should not overflow
         qiov->size anyway (thanks to bdrv_check_qiov_request())
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-14-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    [eblake: grammar tweak]
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Loading