Skip to content
  • Thomas Huth's avatar
    84ebd3e8
    watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable · 84ebd3e8
    Thomas Huth authored
    
    
    QEMU currently aborts when the user tries to hot-unplug a diag288
    device:
    
    $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio
    QEMU 2.9.92 monitor - type 'help' for more information
    (qemu) device_add diag288,id=x
    (qemu) device_del x
    **
    ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
    Aborted (core dumped)
    
    The device is not designed as hot-pluggable (it should only be used
    via the "-watchdog" parameter), so let's simply remove the possibility
    to hotplug it to prevent that users can run into this ugly situation.
    
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    Message-Id: <1502892528-22618-1-git-send-email-thuth@redhat.com>
    Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
    Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
    84ebd3e8
    watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable
    Thomas Huth authored
    
    
    QEMU currently aborts when the user tries to hot-unplug a diag288
    device:
    
    $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio
    QEMU 2.9.92 monitor - type 'help' for more information
    (qemu) device_add diag288,id=x
    (qemu) device_del x
    **
    ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
    Aborted (core dumped)
    
    The device is not designed as hot-pluggable (it should only be used
    via the "-watchdog" parameter), so let's simply remove the possibility
    to hotplug it to prevent that users can run into this ugly situation.
    
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    Message-Id: <1502892528-22618-1-git-send-email-thuth@redhat.com>
    Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
    Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
Loading