-
Daniel P. Berrangé authored
While the QIOChannel APIs for reading/writing data return ssize_t, with negative value indicating an error, the VNC code passes this return value through the vnc_client_io_error() method. This detects the error condition, disconnects the client and returns 0 to indicate error. Thus all the VNC helper methods should return size_t (unsigned), and misleading comments which refer to the possibility of negative return values need fixing. Signed-off-by:
Daniel P. Berrange <berrange@redhat.com>
Reviewed-by:
Darren Kenny <darren.kenny@oracle.com>
Reviewed-by:
Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-14-berrange@redhat.com
Signed-off-by:
Gerd Hoffmann <kraxel@redhat.com>Daniel P. Berrangé authoredWhile the QIOChannel APIs for reading/writing data return ssize_t, with negative value indicating an error, the VNC code passes this return value through the vnc_client_io_error() method. This detects the error condition, disconnects the client and returns 0 to indicate error. Thus all the VNC helper methods should return size_t (unsigned), and misleading comments which refer to the possibility of negative return values need fixing. Signed-off-by:
Daniel P. Berrange <berrange@redhat.com>
Reviewed-by:
Darren Kenny <darren.kenny@oracle.com>
Reviewed-by:
Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-14-berrange@redhat.com
Signed-off-by:
Gerd Hoffmann <kraxel@redhat.com>
Loading