Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    7f4a396d
    qapi: block-stream: add "bottom" argument · 7f4a396d
    Vladimir Sementsov-Ogievskiy authored
    
    
    The code already don't freeze base node and we try to make it prepared
    for the situation when base node is changed during the operation. In
    other words, block-stream doesn't own base node.
    
    Let's introduce a new interface which should replace the current one,
    which will in better relations with the code. Specifying bottom node
    instead of base, and requiring it to be non-filter gives us the
    following benefits:
    
     - drop difference between above_base and base_overlay, which will be
       renamed to just bottom, when old interface dropped
    
     - clean way to work with parallel streams/commits on the same backing
       chain, which otherwise become a problem when we introduce a filter
       for stream job
    
     - cleaner interface. Nobody will surprised the fact that base node may
       disappear during block-stream, when there is no word about "base" in
       the interface.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201216061703.70908-11-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    7f4a396d
    qapi: block-stream: add "bottom" argument
    Vladimir Sementsov-Ogievskiy authored
    
    
    The code already don't freeze base node and we try to make it prepared
    for the situation when base node is changed during the operation. In
    other words, block-stream doesn't own base node.
    
    Let's introduce a new interface which should replace the current one,
    which will in better relations with the code. Specifying bottom node
    instead of base, and requiring it to be non-filter gives us the
    following benefits:
    
     - drop difference between above_base and base_overlay, which will be
       renamed to just bottom, when old interface dropped
    
     - clean way to work with parallel streams/commits on the same backing
       chain, which otherwise become a problem when we introduce a filter
       for stream job
    
     - cleaner interface. Nobody will surprised the fact that base node may
       disappear during block-stream, when there is no word about "base" in
       the interface.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201216061703.70908-11-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading