Skip to content
  • Alberto Garcia's avatar
    7f0317cf
    blockjob: Add 'job_id' parameter to block_job_create() · 7f0317cf
    Alberto Garcia authored
    
    
    When a new job is created, the job ID is taken from the device name of
    the BDS. This patch adds a new 'job_id' parameter to let the caller
    provide one instead.
    
    This patch also verifies that the ID is always unique and well-formed.
    This causes problems in a couple of places where no ID is being set,
    because the BDS does not have a device name.
    
    In the case of test_block_job_start() (from test-blockjob-txn.c) we
    can simply use this new 'job_id' parameter to set the missing ID.
    
    In the case of img_commit() (from qemu-img.c) we still don't have the
    API to make commit_active_start() set the job ID, so we solve it by
    setting a default value. We'll get rid of this as soon as we extend
    the API.
    
    Signed-off-by: default avatarAlberto Garcia <berto@igalia.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    7f0317cf
    blockjob: Add 'job_id' parameter to block_job_create()
    Alberto Garcia authored
    
    
    When a new job is created, the job ID is taken from the device name of
    the BDS. This patch adds a new 'job_id' parameter to let the caller
    provide one instead.
    
    This patch also verifies that the ID is always unique and well-formed.
    This causes problems in a couple of places where no ID is being set,
    because the BDS does not have a device name.
    
    In the case of test_block_job_start() (from test-blockjob-txn.c) we
    can simply use this new 'job_id' parameter to set the missing ID.
    
    In the case of img_commit() (from qemu-img.c) we still don't have the
    API to make commit_active_start() set the job ID, so we solve it by
    setting a default value. We'll get rid of this as soon as we extend
    the API.
    
    Signed-off-by: default avatarAlberto Garcia <berto@igalia.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading