Skip to content
  • Laszlo Ersek's avatar
    6cd2234c
    i386/pc_q35: don't insist on board FDC if there's no default floppy · 6cd2234c
    Laszlo Ersek authored
    
    
    The "no_floppy = 1" machine class setting causes "default_floppy" in
    main() to become zero. Consequently, default_drive() will not call
    drive_add() and drive_new() for IF_FLOPPY, index=0, meaning that no
    default floppy drive will be created for the virtual machine. In that
    case, board code should also not insist on the creation of the
    board-default FDC.
    
    The board-default FDC will still be created if the user requests a floppy
    drive with "-drive if=floppy".
    
    Additionally, separate FDCs can be specified manually with "-device
    isa-fdc". They allow the
    
      -device isa-fdc,driveA=...
    
    syntax that is more flexible than the one required by the board-default
    FDC:
    
      -global isa-fdc.driveA=...
    
    This patch doesn't change the behavior observably, as all Q35 machine
    types have "no_floppy = 0".
    
    Cc: Markus Armbruster <armbru@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Cc: John Snow <jsnow@redhat.com>
    Cc: "Gabriel L. Somlo" <gsomlo@gmail.com>
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    6cd2234c
    i386/pc_q35: don't insist on board FDC if there's no default floppy
    Laszlo Ersek authored
    
    
    The "no_floppy = 1" machine class setting causes "default_floppy" in
    main() to become zero. Consequently, default_drive() will not call
    drive_add() and drive_new() for IF_FLOPPY, index=0, meaning that no
    default floppy drive will be created for the virtual machine. In that
    case, board code should also not insist on the creation of the
    board-default FDC.
    
    The board-default FDC will still be created if the user requests a floppy
    drive with "-drive if=floppy".
    
    Additionally, separate FDCs can be specified manually with "-device
    isa-fdc". They allow the
    
      -device isa-fdc,driveA=...
    
    syntax that is more flexible than the one required by the board-default
    FDC:
    
      -global isa-fdc.driveA=...
    
    This patch doesn't change the behavior observably, as all Q35 machine
    types have "no_floppy = 0".
    
    Cc: Markus Armbruster <armbru@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Cc: John Snow <jsnow@redhat.com>
    Cc: "Gabriel L. Somlo" <gsomlo@gmail.com>
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Loading