Skip to content
  • Markus Armbruster's avatar
    674ed722
    qmp qemu-ga: Fix qemu-ga not to accept "control" · 674ed722
    Markus Armbruster authored
    
    
    Commit cf869d53 "qmp: support out-of-band (oob) execution"
    accidentally made qemu-ga accept and ignore "control".  Fix that.
    
    Out-of-band execution in a monitor that doesn't support it now fails
    with
    
        {"error": {"class": "GenericError", "desc": "QMP input member 'control' is unexpected"}}
    
    instead of
    
        {"error": {"class": "GenericError", "desc": "Please enable out-of-band first for the session during capabilities negotiation"}}
    
    The old description is suboptimal when out-of-band cannot not be
    enabled, or the command doesn't support out-of-band execution.
    
    The new description is a bit unspecific, but it'll do.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20180703085358.13941-12-armbru@redhat.com>
    674ed722
    qmp qemu-ga: Fix qemu-ga not to accept "control"
    Markus Armbruster authored
    
    
    Commit cf869d53 "qmp: support out-of-band (oob) execution"
    accidentally made qemu-ga accept and ignore "control".  Fix that.
    
    Out-of-band execution in a monitor that doesn't support it now fails
    with
    
        {"error": {"class": "GenericError", "desc": "QMP input member 'control' is unexpected"}}
    
    instead of
    
        {"error": {"class": "GenericError", "desc": "Please enable out-of-band first for the session during capabilities negotiation"}}
    
    The old description is suboptimal when out-of-band cannot not be
    enabled, or the command doesn't support out-of-band execution.
    
    The new description is a bit unspecific, but it'll do.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20180703085358.13941-12-armbru@redhat.com>
Loading