Skip to content
  • Taylor Simpson's avatar
    661ad999
    Hexagon (target/hexagon) move store size tracking to translation · 661ad999
    Taylor Simpson authored
    
    
    The store width is needed for packet commit, so it is stored in
    ctx->store_width.  Currently, it is set when a store has a TCG
    override instead of a QEMU helper.  In the QEMU helper case, the
    ctx->store_width is not set, we invoke a helper during packet commit
    that uses the runtime store width.
    
    This patch ensures ctx->store_width is set for all store instructions,
    so performance is improved because packet commit can generate the proper
    TCG store rather than the generic helper.
    
    We do this by
    - Use the attributes from the instructions during translation to
      set ctx->store_width
    - Remove setting of ctx->store_width from genptr.c
    
    Signed-off-by: default avatarTaylor Simpson <tsimpson@quicinc.com>
    Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
    Message-Id: <20220920080746.26791-3-tsimpson@quicinc.com>
    661ad999
    Hexagon (target/hexagon) move store size tracking to translation
    Taylor Simpson authored
    
    
    The store width is needed for packet commit, so it is stored in
    ctx->store_width.  Currently, it is set when a store has a TCG
    override instead of a QEMU helper.  In the QEMU helper case, the
    ctx->store_width is not set, we invoke a helper during packet commit
    that uses the runtime store width.
    
    This patch ensures ctx->store_width is set for all store instructions,
    so performance is improved because packet commit can generate the proper
    TCG store rather than the generic helper.
    
    We do this by
    - Use the attributes from the instructions during translation to
      set ctx->store_width
    - Remove setting of ctx->store_width from genptr.c
    
    Signed-off-by: default avatarTaylor Simpson <tsimpson@quicinc.com>
    Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
    Message-Id: <20220920080746.26791-3-tsimpson@quicinc.com>
Loading