Skip to content
  • Vivek Goyal's avatar
    65a820d2
    virtiofsd: Add an option to enable/disable posix acls · 65a820d2
    Vivek Goyal authored
    
    
    fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse
    server to enable posix acls. As of now we are not opting in for this,
    so posix acls are disabled on virtiofs by default.
    
    Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable
    posix acl support. By default it is disabled as of now due to performance
    concerns with cache=none.
    
    Currently even if file server has not opted in for FUSE_POSIX_ACL, user can
    still query acl and set acl, and system.posix_acl_access and
    system.posix_acl_default xattrs show up listxattr response.
    
    Miklos said this is confusing. So he said lets block and filter
    system.posix_acl_access and system.posix_acl_default xattrs in
    getxattr/setxattr/listxattr if user has explicitly disabled
    posix acls using -o no_posix_acl.
    
    As of now continuing to keeping the existing behavior if user did not
    specify any option to disable acl support due to concerns about backward
    compatibility.
    
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Message-Id: <20210622150852.1507204-8-vgoyal@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    65a820d2
    virtiofsd: Add an option to enable/disable posix acls
    Vivek Goyal authored
    
    
    fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse
    server to enable posix acls. As of now we are not opting in for this,
    so posix acls are disabled on virtiofs by default.
    
    Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable
    posix acl support. By default it is disabled as of now due to performance
    concerns with cache=none.
    
    Currently even if file server has not opted in for FUSE_POSIX_ACL, user can
    still query acl and set acl, and system.posix_acl_access and
    system.posix_acl_default xattrs show up listxattr response.
    
    Miklos said this is confusing. So he said lets block and filter
    system.posix_acl_access and system.posix_acl_default xattrs in
    getxattr/setxattr/listxattr if user has explicitly disabled
    posix acls using -o no_posix_acl.
    
    As of now continuing to keeping the existing behavior if user did not
    specify any option to disable acl support due to concerns about backward
    compatibility.
    
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Message-Id: <20210622150852.1507204-8-vgoyal@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Loading