Skip to content
  • Ladi Prosek's avatar
    60253ed1
    rng: add request queue support to rng-random · 60253ed1
    Ladi Prosek authored
    
    
    Requests are now created in the RngBackend parent class and the
    code path is shared by both rng-egd and rng-random.
    
    This commit fixes the rng-random implementation which processed
    only one request at a time and simply discarded all but the most
    recent one. In the guest this manifested as delayed completion
    of reads from virtio-rng, i.e. a read was completed only after
    another read was issued.
    
    By switching rng-random to use the same request queue as rng-egd,
    the unsafe stack-based allocation of the entropy buffer is
    eliminated and replaced with g_malloc.
    
    Signed-off-by: default avatarLadi Prosek <lprosek@redhat.com>
    Reviewed-by: default avatarAmit Shah <amit.shah@redhat.com>
    Message-Id: <1456994238-9585-5-git-send-email-lprosek@redhat.com>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
    60253ed1
    rng: add request queue support to rng-random
    Ladi Prosek authored
    
    
    Requests are now created in the RngBackend parent class and the
    code path is shared by both rng-egd and rng-random.
    
    This commit fixes the rng-random implementation which processed
    only one request at a time and simply discarded all but the most
    recent one. In the guest this manifested as delayed completion
    of reads from virtio-rng, i.e. a read was completed only after
    another read was issued.
    
    By switching rng-random to use the same request queue as rng-egd,
    the unsafe stack-based allocation of the entropy buffer is
    eliminated and replaced with g_malloc.
    
    Signed-off-by: default avatarLadi Prosek <lprosek@redhat.com>
    Reviewed-by: default avatarAmit Shah <amit.shah@redhat.com>
    Message-Id: <1456994238-9585-5-git-send-email-lprosek@redhat.com>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Loading