Skip to content
  • Kevin Wolf's avatar
    5fbfabd3
    block: Formats don't need CONSISTENT_READ with NO_IO · 5fbfabd3
    Kevin Wolf authored
    
    
    Commit 1f4ad7d3 fixed 'qemu-img info' for raw images that are currently
    in use as a mirror target. It is not enough for image formats, though,
    as these still unconditionally request BLK_PERM_CONSISTENT_READ.
    
    As this permission is geared towards whether the guest-visible data is
    consistent, and has no impact on whether the metadata is sane, and
    'qemu-img info' does not read guest-visible data (except for the raw
    format), it makes sense to not require BLK_PERM_CONSISTENT_READ if there
    is not going to be any guest I/O performed, regardless of image format.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    5fbfabd3
    block: Formats don't need CONSISTENT_READ with NO_IO
    Kevin Wolf authored
    
    
    Commit 1f4ad7d3 fixed 'qemu-img info' for raw images that are currently
    in use as a mirror target. It is not enough for image formats, though,
    as these still unconditionally request BLK_PERM_CONSISTENT_READ.
    
    As this permission is geared towards whether the guest-visible data is
    consistent, and has no impact on whether the metadata is sane, and
    'qemu-img info' does not read guest-visible data (except for the raw
    format), it makes sense to not require BLK_PERM_CONSISTENT_READ if there
    is not going to be any guest I/O performed, regardless of image format.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading