Skip to content
  • Paolo Bonzini's avatar
    5914ef77
    Makefile: separate meson rerun from the rest of the ninja invocation · 5914ef77
    Paolo Bonzini authored
    
    
    The rules to build Makefile.mtest are suffering from the "tunnel vision"
    problem that is common with recursive makefiles.  Makefile.mtest depends
    on build.ninja, but Make does not know when build.ninja needs to be
    rebuilt before creating Makefile.mtest.
    
    To fix this, separate the ninja invocation into the "regenerate build
    files" phase and the QEMU build phase.  Sentinel files such as
    meson-private/coredata.dat or build.ninja are used to figure out the
    phases that haven't run yet; however, because those files' timestamps
    are not guaranteed to be touched, the usual makefile stamp-file trick
    is used on top.
    
    Reported-by: default avatarHavard Skinnemoen <hskinnemoen@gmail.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    5914ef77
    Makefile: separate meson rerun from the rest of the ninja invocation
    Paolo Bonzini authored
    
    
    The rules to build Makefile.mtest are suffering from the "tunnel vision"
    problem that is common with recursive makefiles.  Makefile.mtest depends
    on build.ninja, but Make does not know when build.ninja needs to be
    rebuilt before creating Makefile.mtest.
    
    To fix this, separate the ninja invocation into the "regenerate build
    files" phase and the QEMU build phase.  Sentinel files such as
    meson-private/coredata.dat or build.ninja are used to figure out the
    phases that haven't run yet; however, because those files' timestamps
    are not guaranteed to be touched, the usual makefile stamp-file trick
    is used on top.
    
    Reported-by: default avatarHavard Skinnemoen <hskinnemoen@gmail.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Loading