Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    548a74c0
    block: add bdrv_attach_child_common() transaction action · 548a74c0
    Vladimir Sementsov-Ogievskiy authored
    
    
    Split out no-perm part of bdrv_root_attach_child() into separate
    transaction action. bdrv_root_attach_child() now moves to new
    permission update paradigm: first update graph relations then update
    permissions.
    
    qsd-jobs test output updated. Seems now permission update goes in
    another order. Still, the test comment say that we only want to check
    that command doesn't crash, and it's still so.
    
    Error message is a bit misleading as it looks like job was added first.
    But actually in new paradigm of graph update we can't distinguish such
    things. We should update the error message, but let's not do it now.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20210428151804.439460-19-vsementsov@virtuozzo.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    548a74c0
    block: add bdrv_attach_child_common() transaction action
    Vladimir Sementsov-Ogievskiy authored
    
    
    Split out no-perm part of bdrv_root_attach_child() into separate
    transaction action. bdrv_root_attach_child() now moves to new
    permission update paradigm: first update graph relations then update
    permissions.
    
    qsd-jobs test output updated. Seems now permission update goes in
    another order. Still, the test comment say that we only want to check
    that command doesn't crash, and it's still so.
    
    Error message is a bit misleading as it looks like job was added first.
    But actually in new paradigm of graph update we can't distinguish such
    things. We should update the error message, but let's not do it now.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20210428151804.439460-19-vsementsov@virtuozzo.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading