-
Vladimir Sementsov-Ogievskiy authored
This is the only coroutine wrapper from block.c and block/io.c which doesn't return a value, so let's convert it to the common behavior, to simplify moving to generated coroutine wrappers in a further commit. Also, bdrv_invalidate_cache is a void function, returning error only through **errp parameter, which is considered to be bad practice, as it forces callers to define and propagate local_err variable, so conversion is good anyway. This patch leaves the conversion of .bdrv_co_invalidate_cache() driver callbacks and bdrv_invalidate_cache_all() for another day. Signed-off-by:
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by:
Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by:
Eric Blake <eblake@redhat.com>
Reviewed-by:
Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by:
Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20200924185414.28642-2-vsementsov@virtuozzo.com>Vladimir Sementsov-Ogievskiy authoredThis is the only coroutine wrapper from block.c and block/io.c which doesn't return a value, so let's convert it to the common behavior, to simplify moving to generated coroutine wrappers in a further commit. Also, bdrv_invalidate_cache is a void function, returning error only through **errp parameter, which is considered to be bad practice, as it forces callers to define and propagate local_err variable, so conversion is good anyway. This patch leaves the conversion of .bdrv_co_invalidate_cache() driver callbacks and bdrv_invalidate_cache_all() for another day. Signed-off-by:
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by:
Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by:
Eric Blake <eblake@redhat.com>
Reviewed-by:
Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by:
Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20200924185414.28642-2-vsementsov@virtuozzo.com>
Loading