Skip to content
  • Kevin Wolf's avatar
    e69ee454
    monitor: Make current monitor a per-coroutine property · e69ee454
    Kevin Wolf authored
    
    
    This way, a monitor command handler will still be able to access the
    current monitor, but when it yields, all other code code will correctly
    get NULL from monitor_cur().
    
    This uses a hash table to map the coroutine pointer to the current
    monitor of that coroutine.  Outside of coroutine context, we associate
    the current monitor with the leader coroutine of the current thread.
    
    Approaches to implement some form of coroutine local storage directly in
    the coroutine core code have been considered and discarded because they
    didn't end up being much more generic than the hash table and their
    performance impact on coroutines not using coroutine local storage was
    unclear. As the block layer uses a coroutine per I/O request, this is a
    fast path and we have to be careful. It's safest to just stay out of
    this path with code only used by the monitor.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20201005155855.256490-8-kwolf@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    e69ee454
    monitor: Make current monitor a per-coroutine property
    Kevin Wolf authored
    
    
    This way, a monitor command handler will still be able to access the
    current monitor, but when it yields, all other code code will correctly
    get NULL from monitor_cur().
    
    This uses a hash table to map the coroutine pointer to the current
    monitor of that coroutine.  Outside of coroutine context, we associate
    the current monitor with the leader coroutine of the current thread.
    
    Approaches to implement some form of coroutine local storage directly in
    the coroutine core code have been considered and discarded because they
    didn't end up being much more generic than the hash table and their
    performance impact on coroutines not using coroutine local storage was
    unclear. As the block layer uses a coroutine per I/O request, this is a
    fast path and we have to be careful. It's safest to just stay out of
    this path with code only used by the monitor.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20201005155855.256490-8-kwolf@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Loading