Skip to content
  • Philippe Mathieu-Daudé's avatar
    52d97058
    hw/pci-host/bonito: Do not use SysBus API to map local MMIO region · 52d97058
    Philippe Mathieu-Daudé authored
    
    
    There is no point in exposing an internal MMIO region via
    SysBus and directly mapping it in the very same device.
    
    Just map it without using the SysBus API.
    
    Transformation done using the following coccinelle script:
    
      @@
      expression sbdev;
      expression index;
      expression addr;
      expression subregion;
      @@
      -    sysbus_init_mmio(sbdev, subregion);
           ... when != sbdev
      -    sysbus_mmio_map(sbdev, index, addr);
      +    memory_region_add_subregion(get_system_memory(), addr, subregion);
    
    and manually adding the local 'host_mem' variable to
    avoid multiple calls to get_system_memory().
    
    Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Message-Id: <20231019071611.98885-6-philmd@linaro.org>
    52d97058
    hw/pci-host/bonito: Do not use SysBus API to map local MMIO region
    Philippe Mathieu-Daudé authored
    
    
    There is no point in exposing an internal MMIO region via
    SysBus and directly mapping it in the very same device.
    
    Just map it without using the SysBus API.
    
    Transformation done using the following coccinelle script:
    
      @@
      expression sbdev;
      expression index;
      expression addr;
      expression subregion;
      @@
      -    sysbus_init_mmio(sbdev, subregion);
           ... when != sbdev
      -    sysbus_mmio_map(sbdev, index, addr);
      +    memory_region_add_subregion(get_system_memory(), addr, subregion);
    
    and manually adding the local 'host_mem' variable to
    avoid multiple calls to get_system_memory().
    
    Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Message-Id: <20231019071611.98885-6-philmd@linaro.org>
Loading