-
Richard Henderson authored
This reverts commit dc09f047. For tcg, tracepoints are expanded inline in tcg opcodes. Using a helper which generates a second tracepoint is incorrect. For system mode, the extraction and re-packing of MemOp and mmu_idx lost the alignment information from MemOp. So we were no longer raising alignment exceptions for !TARGET_ALIGNED_ONLY guests. This can be seen in tests/tcg/xtensa/test_load_store.S. For user mode, we must update to the new signature of g2h() so that the revert compiles. We can leave set_helper_retaddr for later. Tested-by:
Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by:
Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by:
Richard Henderson <richard.henderson@linaro.org>Richard Henderson authoredThis reverts commit dc09f047. For tcg, tracepoints are expanded inline in tcg opcodes. Using a helper which generates a second tracepoint is incorrect. For system mode, the extraction and re-packing of MemOp and mmu_idx lost the alignment information from MemOp. So we were no longer raising alignment exceptions for !TARGET_ALIGNED_ONLY guests. This can be seen in tests/tcg/xtensa/test_load_store.S. For user mode, we must update to the new signature of g2h() so that the revert compiles. We can leave set_helper_retaddr for later. Tested-by:
Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by:
Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by:
Richard Henderson <richard.henderson@linaro.org>
Loading