Skip to content
  • Jeff Cody's avatar
    30af51ce
    block: vhdx - change .vhdx_create default block state to ZERO · 30af51ce
    Jeff Cody authored
    
    
    The VHDX spec specifies that the default new block state is
    PAYLOAD_BLOCK_NOT_PRESENT for a dynamic VHDX image, and
    PAYLOAD_BLOCK_FULLY_PRESENT for a fixed VHDX image.
    
    However, in order to create space-efficient VHDX images with qemu-img
    convert, it is desirable to be able to set has_zero_init to true for
    VHDX.
    
    There is currently an option when creating VHDX images, to use block
    state ZERO for new blocks.  However, this currently defaults to 'off'.
    In order to be able to eventually set has_zero_init to true for VHDX,
    this needs to default to 'on'.
    
    This patch changes the default to 'on', and provides some help
    information to warn against setting it to 'off' when using qemu-img
    convert.
    
    [Max Reitz pointed out that a full stop was missing at the end of the
    VHDX_BLOCK_OPT_ZERO option help text.  I have added it.
    --Stefan]
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 85164899eacc86e150c3ceba793cf93b398dedd7.1418018421.git.jcody@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    30af51ce
    block: vhdx - change .vhdx_create default block state to ZERO
    Jeff Cody authored
    
    
    The VHDX spec specifies that the default new block state is
    PAYLOAD_BLOCK_NOT_PRESENT for a dynamic VHDX image, and
    PAYLOAD_BLOCK_FULLY_PRESENT for a fixed VHDX image.
    
    However, in order to create space-efficient VHDX images with qemu-img
    convert, it is desirable to be able to set has_zero_init to true for
    VHDX.
    
    There is currently an option when creating VHDX images, to use block
    state ZERO for new blocks.  However, this currently defaults to 'off'.
    In order to be able to eventually set has_zero_init to true for VHDX,
    this needs to default to 'on'.
    
    This patch changes the default to 'on', and provides some help
    information to warn against setting it to 'off' when using qemu-img
    convert.
    
    [Max Reitz pointed out that a full stop was missing at the end of the
    VHDX_BLOCK_OPT_ZERO option help text.  I have added it.
    --Stefan]
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 85164899eacc86e150c3ceba793cf93b398dedd7.1418018421.git.jcody@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Loading