Skip to content
  • Eric Blake's avatar
    4c40314a
    qapi: Prefer type_int64 over type_int in visitors · 4c40314a
    Eric Blake authored
    
    
    The qapi builtin type 'int' is basically shorthand for the type
    'int64'.  In fact, since no visitor was providing the optional
    type_int64() callback, visit_type_int64() was just always falling
    back to type_int(), cementing the equivalence between the types.
    
    However, some visitors are providing a type_uint64() callback.
    For purposes of code consistency, it is nicer if all visitors
    use the paired type_int64/type_uint64 names rather than the
    mismatched type_int/type_uint64.  So this patch just renames
    the signed int callbacks in place, dropping the type_int()
    callback as redundant, and a later patch will focus on the
    unsigned int callbacks.
    
    Add some FIXMEs to questionable reuse of errp in code touched
    by the rename, while at it (the reuse works as long as the
    callbacks don't modify value when setting an error, but it's not
    a good example to set) - a later patch will then fix those.
    
    No change in functionality here, although further cleanups are
    in the pipeline.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <1454075341-13658-14-git-send-email-eblake@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    4c40314a
    qapi: Prefer type_int64 over type_int in visitors
    Eric Blake authored
    
    
    The qapi builtin type 'int' is basically shorthand for the type
    'int64'.  In fact, since no visitor was providing the optional
    type_int64() callback, visit_type_int64() was just always falling
    back to type_int(), cementing the equivalence between the types.
    
    However, some visitors are providing a type_uint64() callback.
    For purposes of code consistency, it is nicer if all visitors
    use the paired type_int64/type_uint64 names rather than the
    mismatched type_int/type_uint64.  So this patch just renames
    the signed int callbacks in place, dropping the type_int()
    callback as redundant, and a later patch will focus on the
    unsigned int callbacks.
    
    Add some FIXMEs to questionable reuse of errp in code touched
    by the rename, while at it (the reuse works as long as the
    callbacks don't modify value when setting an error, but it's not
    a good example to set) - a later patch will then fix those.
    
    No change in functionality here, although further cleanups are
    in the pipeline.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <1454075341-13658-14-git-send-email-eblake@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Loading