-
Markus Armbruster authored
object_property_get_enum() is the only object_property_FOO() that is documented to return an undefined value on error. It does no such thing, actually: it returns 0 on some errors, and -1 on others. Needlessly complicated. Always return -1 on error, and adjust the contract. Signed-off-by:
Markus Armbruster <armbru@redhat.com>
Reviewed-by:
Greg Kurz <groug@kaod.org>
Reviewed-by:
Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200917125540.597786-2-armbru@redhat.com>
Signed-off-by:
Eduardo Habkost <ehabkost@redhat.com>Markus Armbruster authoredobject_property_get_enum() is the only object_property_FOO() that is documented to return an undefined value on error. It does no such thing, actually: it returns 0 on some errors, and -1 on others. Needlessly complicated. Always return -1 on error, and adjust the contract. Signed-off-by:
Markus Armbruster <armbru@redhat.com>
Reviewed-by:
Greg Kurz <groug@kaod.org>
Reviewed-by:
Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200917125540.597786-2-armbru@redhat.com>
Signed-off-by:
Eduardo Habkost <ehabkost@redhat.com>
Loading