Skip to content
  • Stefan Hajnoczi's avatar
    7a63f3cd
    block: update bdrv_drain_all()/bdrv_drain() comments · 7a63f3cd
    Stefan Hajnoczi authored
    
    
    The doc comments for bdrv_drain_all() and bdrv_drain() are outdated:
    
     * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock()
       which Fam Zheng is currently developing.  Unfortunately this warning
       was never really enough because devices keep submitting I/O and op
       blockers don't prevent that.
    
     * The bdrv_drain_all() comment is still partially correct but reflects
       the nature of the implementation rather than API documentation.
    
    Do make it clear that bdrv_drain() is only appropriate within an
    AioContext.  For anything spanning AioContexts you need
    bdrv_drain_all().
    
    Cc: Markus Armbruster <armbru@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarFam Zheng <famz@redhat.com>
    Message-id: 1435854281-6078-1-git-send-email-stefanha@redhat.com
    7a63f3cd
    block: update bdrv_drain_all()/bdrv_drain() comments
    Stefan Hajnoczi authored
    
    
    The doc comments for bdrv_drain_all() and bdrv_drain() are outdated:
    
     * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock()
       which Fam Zheng is currently developing.  Unfortunately this warning
       was never really enough because devices keep submitting I/O and op
       blockers don't prevent that.
    
     * The bdrv_drain_all() comment is still partially correct but reflects
       the nature of the implementation rather than API documentation.
    
    Do make it clear that bdrv_drain() is only appropriate within an
    AioContext.  For anything spanning AioContexts you need
    bdrv_drain_all().
    
    Cc: Markus Armbruster <armbru@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarFam Zheng <famz@redhat.com>
    Message-id: 1435854281-6078-1-git-send-email-stefanha@redhat.com
Loading