Skip to content
  • Jeff Cody's avatar
    6133b39f
    coroutine: abort if we try to schedule or enter a pending coroutine · 6133b39f
    Jeff Cody authored
    
    
    The previous patch fixed a race condition, in which there were
    coroutines being executing doubly, or after coroutine deletion.
    
    We can detect common scenarios when this happens, and print an error
    message and abort before we corrupt memory / data, or segfault.
    
    This patch will abort if an attempt to enter a coroutine is made while
    it is currently pending execution, either in a specific AioContext bh,
    or pending execution via a timer.  It will also abort if a coroutine
    is scheduled, before a prior scheduled run has occurred.
    
    We cannot rely on the existing co->caller check for recursive re-entry
    to catch this, as the coroutine may run and exit with
    COROUTINE_TERMINATE before the scheduled coroutine executes.
    
    (This is the scenario that was occurring and fixed in the previous
    patch).
    
    This patch also re-orders the Coroutine struct elements in an attempt to
    optimize caching.
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    6133b39f
    coroutine: abort if we try to schedule or enter a pending coroutine
    Jeff Cody authored
    
    
    The previous patch fixed a race condition, in which there were
    coroutines being executing doubly, or after coroutine deletion.
    
    We can detect common scenarios when this happens, and print an error
    message and abort before we corrupt memory / data, or segfault.
    
    This patch will abort if an attempt to enter a coroutine is made while
    it is currently pending execution, either in a specific AioContext bh,
    or pending execution via a timer.  It will also abort if a coroutine
    is scheduled, before a prior scheduled run has occurred.
    
    We cannot rely on the existing co->caller check for recursive re-entry
    to catch this, as the coroutine may run and exit with
    COROUTINE_TERMINATE before the scheduled coroutine executes.
    
    (This is the scenario that was occurring and fixed in the previous
    patch).
    
    This patch also re-orders the Coroutine struct elements in an attempt to
    optimize caching.
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Loading