Skip to content
  • Kevin Wolf's avatar
    41869044
    block: Fix snapshot=on with aio=native · 41869044
    Kevin Wolf authored
    
    
    snapshot=on creates a temporary overlay that is always opened with
    cache=unsafe (the cache mode specified by the user is only for the
    actual image file and its children). This means that we must not inherit
    the BDRV_O_NATIVE_AIO flag for the temporary overlay because trying to
    use Linux AIO with cache=unsafe results in an error.
    
    Reproducer without this patch:
    
    $ x86_64-softmmu/qemu-system-x86_64 -drive file=/tmp/test.qcow2,cache=none,aio=native,snapshot=on
    qemu-system-x86_64: -drive file=/tmp/test.qcow2,cache=none,aio=native,snapshot=on: aio=native was
    specified, but it requires cache.direct=on, which was not specified.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    41869044
    block: Fix snapshot=on with aio=native
    Kevin Wolf authored
    
    
    snapshot=on creates a temporary overlay that is always opened with
    cache=unsafe (the cache mode specified by the user is only for the
    actual image file and its children). This means that we must not inherit
    the BDRV_O_NATIVE_AIO flag for the temporary overlay because trying to
    use Linux AIO with cache=unsafe results in an error.
    
    Reproducer without this patch:
    
    $ x86_64-softmmu/qemu-system-x86_64 -drive file=/tmp/test.qcow2,cache=none,aio=native,snapshot=on
    qemu-system-x86_64: -drive file=/tmp/test.qcow2,cache=none,aio=native,snapshot=on: aio=native was
    specified, but it requires cache.direct=on, which was not specified.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading