Skip to content
  • Jeff Cody's avatar
    418661e0
    block: check full backing filename when searching protocol filenames · 418661e0
    Jeff Cody authored
    
    
    In bdrv_find_backing_image(), if we are searching an image for a backing
    file that contains a protocol, we currently only compare unmodified
    paths.
    
    However, some management software will change the backing filename to be
    a relative filename in a path.  QEMU is able to handle this fine,
    because internally it will use path_combine to put together the full
    protocol URI.
    
    However, this can lead to an inability to match an image during a QAPI
    command that needs to use bdrv_find_backing_image() to find the image,
    when it is searched by the full URI.
    
    When searching for a protocol filename, if the straight comparison
    fails, this patch will also compare against the full backing filename to
    see if that is a match.
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Message-id: c2d025adca8a2b665189e6f4cf080f44126d0b6b.1485392617.git.jcody@redhat.com
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    418661e0
    block: check full backing filename when searching protocol filenames
    Jeff Cody authored
    
    
    In bdrv_find_backing_image(), if we are searching an image for a backing
    file that contains a protocol, we currently only compare unmodified
    paths.
    
    However, some management software will change the backing filename to be
    a relative filename in a path.  QEMU is able to handle this fine,
    because internally it will use path_combine to put together the full
    protocol URI.
    
    However, this can lead to an inability to match an image during a QAPI
    command that needs to use bdrv_find_backing_image() to find the image,
    when it is searched by the full URI.
    
    When searching for a protocol filename, if the straight comparison
    fails, this patch will also compare against the full backing filename to
    see if that is a match.
    
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    Message-id: c2d025adca8a2b665189e6f4cf080f44126d0b6b.1485392617.git.jcody@redhat.com
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading