Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    86c6a3b6
    qapi: backup: add perf.use-copy-range parameter · 86c6a3b6
    Vladimir Sementsov-Ogievskiy authored
    
    
    Experiments show, that copy_range is not always making things faster.
    So, to make experimentation simpler, let's add a parameter. Some more
    perf parameters will be added soon, so here is a new struct.
    
    For now, add new backup qmp parameter with x- prefix for the following
    reasons:
    
     - We are going to add more performance parameters, some will be
       related to the whole block-copy process, some only to background
       copying in backup (ignored for copy-before-write operations).
     - On the other hand, we are going to use block-copy interface in other
       block jobs, which will need performance options as well.. And it
       should be the same structure or at least somehow related.
    
    So, there are too much unclean things about how the interface and now
    we need the new options mostly for testing. Let's keep them
    experimental for a while.
    
    In do_backup_common() new x-perf parameter handled in a way to
    make further options addition simpler.
    
    We add use-copy-range with default=true, and we'll change the default
    in further patch, after moving backup to use block-copy.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20210116214705.822267-2-vsementsov@virtuozzo.com>
    [mreitz: s/5\.2/6.0/]
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    86c6a3b6
    qapi: backup: add perf.use-copy-range parameter
    Vladimir Sementsov-Ogievskiy authored
    
    
    Experiments show, that copy_range is not always making things faster.
    So, to make experimentation simpler, let's add a parameter. Some more
    perf parameters will be added soon, so here is a new struct.
    
    For now, add new backup qmp parameter with x- prefix for the following
    reasons:
    
     - We are going to add more performance parameters, some will be
       related to the whole block-copy process, some only to background
       copying in backup (ignored for copy-before-write operations).
     - On the other hand, we are going to use block-copy interface in other
       block jobs, which will need performance options as well.. And it
       should be the same structure or at least somehow related.
    
    So, there are too much unclean things about how the interface and now
    we need the new options mostly for testing. Let's keep them
    experimental for a while.
    
    In do_backup_common() new x-perf parameter handled in a way to
    make further options addition simpler.
    
    We add use-copy-range with default=true, and we'll change the default
    in further patch, after moving backup to use block-copy.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20210116214705.822267-2-vsementsov@virtuozzo.com>
    [mreitz: s/5\.2/6.0/]
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading