Skip to content
  • Maxim Levitsky's avatar
    3d1900a4
    block: luks: better error message when creating too large files · 3d1900a4
    Maxim Levitsky authored
    Currently if you attampt to create too large file with luks you
    get the following error message:
    
    Formatting 'test.luks', fmt=luks size=17592186044416 key-secret=sec0
    qemu-img: test.luks: Could not resize file: File too large
    
    While for raw format the error message is
    qemu-img: test.img: The image size is too large for file format 'raw'
    
    The reason for this is that qemu-img checks for errono of the failure,
    and presents the later error when it is -EFBIG
    
    However crypto generic code 'swallows' the errno and replaces it
    with -EIO.
    
    As an attempt to make it better, we can make luks driver,
    detect -EFBIG and in this case present a better error message,
    which is what this patch does
    
    The new error message is:
    
    qemu-img: error creating test.luks: The requested file size is too large
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534898
    
    
    Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
    3d1900a4
    block: luks: better error message when creating too large files
    Maxim Levitsky authored
    Currently if you attampt to create too large file with luks you
    get the following error message:
    
    Formatting 'test.luks', fmt=luks size=17592186044416 key-secret=sec0
    qemu-img: test.luks: Could not resize file: File too large
    
    While for raw format the error message is
    qemu-img: test.img: The image size is too large for file format 'raw'
    
    The reason for this is that qemu-img checks for errono of the failure,
    and presents the later error when it is -EFBIG
    
    However crypto generic code 'swallows' the errno and replaces it
    with -EIO.
    
    As an attempt to make it better, we can make luks driver,
    detect -EFBIG and in this case present a better error message,
    which is what this patch does
    
    The new error message is:
    
    qemu-img: error creating test.luks: The requested file size is too large
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534898
    
    
    Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Loading