Skip to content
  • Volker Rümelin's avatar
    3c4b8f83
    ui/gtk: limit virtual console max update interval · 3c4b8f83
    Volker Rümelin authored
    Limit the virtual console maximum update interval to
    GUI_REFRESH_INTERVAL_DEFAULT. This papers over a integer
    overflow bug in gtk3 on Windows where the reported monitor
    refresh frequency can be much smaller than the real refresh
    frequency.
    
    The gtk bug report can be found here:
    https://gitlab.gnome.org/GNOME/gtk/-/issues/3394
    
    
    
    On my Windows 10 system gtk reports a monitor refresh rate of
    1.511Hz instead of 60.031Hz and slows down the screen update
    rate in qemu to a crawl. Provided you are affected by the gtk
    bug on Windows, these are the steps to reproduce the issue:
    
    Start qemu with -display gtk and activate all qemu virtual
    consoles and notice the reduced qemu refresh rate. Activating
    all virtual consoles is necessary, because gui_update() in
    ui/console.c uses the minimum of all display change listeners
    update interval and not yet activated virtual consoles report
    the default update interval (30ms).
    
    Signed-off-by: default avatarVolker Rümelin <vr_qemu@t-online.de>
    Message-Id: <20201213165724.13418-3-vr_qemu@t-online.de>
    Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
    3c4b8f83
    ui/gtk: limit virtual console max update interval
    Volker Rümelin authored
    Limit the virtual console maximum update interval to
    GUI_REFRESH_INTERVAL_DEFAULT. This papers over a integer
    overflow bug in gtk3 on Windows where the reported monitor
    refresh frequency can be much smaller than the real refresh
    frequency.
    
    The gtk bug report can be found here:
    https://gitlab.gnome.org/GNOME/gtk/-/issues/3394
    
    
    
    On my Windows 10 system gtk reports a monitor refresh rate of
    1.511Hz instead of 60.031Hz and slows down the screen update
    rate in qemu to a crawl. Provided you are affected by the gtk
    bug on Windows, these are the steps to reproduce the issue:
    
    Start qemu with -display gtk and activate all qemu virtual
    consoles and notice the reduced qemu refresh rate. Activating
    all virtual consoles is necessary, because gui_update() in
    ui/console.c uses the minimum of all display change listeners
    update interval and not yet activated virtual consoles report
    the default update interval (30ms).
    
    Signed-off-by: default avatarVolker Rümelin <vr_qemu@t-online.de>
    Message-Id: <20201213165724.13418-3-vr_qemu@t-online.de>
    Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Loading