Skip to content
  • Eric Blake's avatar
    3b51ab4b
    qemu-img: Add bitmap sub-command · 3b51ab4b
    Eric Blake authored
    
    
    Include actions for --add, --remove, --clear, --enable, --disable, and
    --merge (note that --clear is a bit of fluff, because the same can be
    accomplished by removing a bitmap and then adding a new one in its
    place, but it matches what QMP commands exist).  Listing is omitted,
    because it does not require a bitmap name and because it was already
    possible with 'qemu-img info'.  A single command line can play one or
    more bitmap commands in sequence on the same bitmap name (although all
    added bitmaps share the same granularity, and and all merged bitmaps
    come from the same source file).  Merge defaults to other bitmaps in
    the primary image, but can also be told to merge bitmaps from a
    distinct image.
    
    While this supports --image-opts for the file being modified, I did
    not think it worth the extra complexity to support that for the source
    file in a cross-file merges.  Likewise, I chose to have --merge only
    take a single source rather than following the QMP support for
    multiple merges in one go (although you can still use more than one
    --merge in the command line); in part because qemu-img is offline and
    therefore atomicity is not an issue.
    
    Upcoming patches will add iotest coverage of these commands while
    also testing other features.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20200513011648.166876-7-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    3b51ab4b
    qemu-img: Add bitmap sub-command
    Eric Blake authored
    
    
    Include actions for --add, --remove, --clear, --enable, --disable, and
    --merge (note that --clear is a bit of fluff, because the same can be
    accomplished by removing a bitmap and then adding a new one in its
    place, but it matches what QMP commands exist).  Listing is omitted,
    because it does not require a bitmap name and because it was already
    possible with 'qemu-img info'.  A single command line can play one or
    more bitmap commands in sequence on the same bitmap name (although all
    added bitmaps share the same granularity, and and all merged bitmaps
    come from the same source file).  Merge defaults to other bitmaps in
    the primary image, but can also be told to merge bitmaps from a
    distinct image.
    
    While this supports --image-opts for the file being modified, I did
    not think it worth the extra complexity to support that for the source
    file in a cross-file merges.  Likewise, I chose to have --merge only
    take a single source rather than following the QMP support for
    multiple merges in one go (although you can still use more than one
    --merge in the command line); in part because qemu-img is offline and
    therefore atomicity is not an issue.
    
    Upcoming patches will add iotest coverage of these commands while
    also testing other features.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20200513011648.166876-7-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Loading