Skip to content
  • Markus Armbruster's avatar
    93f8f982
    monitor: Simplify event throttling · 93f8f982
    Markus Armbruster authored
    
    
    The event throttling state machine is hard to understand.  I'm not
    sure it's entirely correct.  Rewrite it in a more straightforward
    manner:
    
    State 1: No event sent recently (less than evconf->rate ns ago)
    
        Invariant: evstate->timer is not pending, evstate->qdict is null
    
        On event: send event, arm timer, goto state 2
    
    State 2: Event sent recently, no additional event being delayed
    
        Invariant: evstate->timer is pending, evstate->qdict is null
    
        On event: store it in evstate->qdict, goto state 3
    
        On timer: goto state 1
    
    State 3: Event sent recently, additional event being delayed
    
        Invariant: evstate->timer is pending, evstate->qdict is non-null
    
        On event: store it in evstate->qdict, goto state 3
    
        On timer: send evstate->qdict, clear evstate->qdict,
                  arm timer, goto state 2
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <1444921716-9511-3-git-send-email-armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    93f8f982
    monitor: Simplify event throttling
    Markus Armbruster authored
    
    
    The event throttling state machine is hard to understand.  I'm not
    sure it's entirely correct.  Rewrite it in a more straightforward
    manner:
    
    State 1: No event sent recently (less than evconf->rate ns ago)
    
        Invariant: evstate->timer is not pending, evstate->qdict is null
    
        On event: send event, arm timer, goto state 2
    
    State 2: Event sent recently, no additional event being delayed
    
        Invariant: evstate->timer is pending, evstate->qdict is null
    
        On event: store it in evstate->qdict, goto state 3
    
        On timer: goto state 1
    
    State 3: Event sent recently, additional event being delayed
    
        Invariant: evstate->timer is pending, evstate->qdict is non-null
    
        On event: store it in evstate->qdict, goto state 3
    
        On timer: send evstate->qdict, clear evstate->qdict,
                  arm timer, goto state 2
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <1444921716-9511-3-git-send-email-armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Loading