Skip to content
  • Anthony Liguori's avatar
    cef3017c
    Clean some PCI defines (Stefan Weil) · cef3017c
    Anthony Liguori authored
    
    
    this patch adds some more defines from linux/pci_regs.h to
    hw/pci.h. There is now no longer a need to define them in
    eepro100.c, so they were removed there.
    
    Some defines from linux/pci_regs.h had similar, but not
    the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION,
    PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID,
    PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID).
    
    I suggest to use the "standard" from linux/pci_regs.h and
    replace the "old" Qemu ones. To facilitate the migration,
    my patch does not remove the old defines but marks them
    as obsolete. After a migration to the "standard" defines,
    pci.h could use linux/pci_regs.h which is far more complete.
    
    The patch is needed for an updated maintainer version of
    hw/eepro100.c which I'd like to see in Qemu stable.
    
     * Remove declarations already declared in header file from eepro100.c
     * Add missing declarations from pci_regs.h to pci.h
     * Mark "non-standard" declarations in pci.h as obsolete
    
    Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
    Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6901 c046a42c-6fe2-441c-8c8c-71466251a162
    cef3017c
    Clean some PCI defines (Stefan Weil)
    Anthony Liguori authored
    
    
    this patch adds some more defines from linux/pci_regs.h to
    hw/pci.h. There is now no longer a need to define them in
    eepro100.c, so they were removed there.
    
    Some defines from linux/pci_regs.h had similar, but not
    the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION,
    PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID,
    PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID).
    
    I suggest to use the "standard" from linux/pci_regs.h and
    replace the "old" Qemu ones. To facilitate the migration,
    my patch does not remove the old defines but marks them
    as obsolete. After a migration to the "standard" defines,
    pci.h could use linux/pci_regs.h which is far more complete.
    
    The patch is needed for an updated maintainer version of
    hw/eepro100.c which I'd like to see in Qemu stable.
    
     * Remove declarations already declared in header file from eepro100.c
     * Add missing declarations from pci_regs.h to pci.h
     * Mark "non-standard" declarations in pci.h as obsolete
    
    Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
    Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6901 c046a42c-6fe2-441c-8c8c-71466251a162
Loading