Skip to content
  • Laszlo Ersek's avatar
    306764ee
    hw/i386/pc: fix code comment on cumulative flash size · 306764ee
    Laszlo Ersek authored
    
    
    - The comment is incorrectly indented / formatted.
    
    - The comment states a 8MB limit, even though the code enforces a 16MB
      limit.
    
    Both of these warts come from commit 0657c657 ("hw/i386/pc: add max
    combined fw size as machine configuration option", 2020-12-09); clean them
    up.
    
    Arguably, it's also better to be consistent with the binary units (such as
    "MiB") that QEMU uses nowadays.
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC)
    Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
    Cc: Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86 TCG CPUs)
    Cc: Richard Henderson <richard.henderson@linaro.org> (maintainer:X86 TCG CPUs)
    Cc: Eduardo Habkost <eduardo@habkost.net> (maintainer:X86 TCG CPUs)
    Cc: qemu-trivial@nongnu.org
    Fixes: 0657c657
    Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
    Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
    306764ee
    hw/i386/pc: fix code comment on cumulative flash size
    Laszlo Ersek authored
    
    
    - The comment is incorrectly indented / formatted.
    
    - The comment states a 8MB limit, even though the code enforces a 16MB
      limit.
    
    Both of these warts come from commit 0657c657 ("hw/i386/pc: add max
    combined fw size as machine configuration option", 2020-12-09); clean them
    up.
    
    Arguably, it's also better to be consistent with the binary units (such as
    "MiB") that QEMU uses nowadays.
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC)
    Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
    Cc: Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86 TCG CPUs)
    Cc: Richard Henderson <richard.henderson@linaro.org> (maintainer:X86 TCG CPUs)
    Cc: Eduardo Habkost <eduardo@habkost.net> (maintainer:X86 TCG CPUs)
    Cc: qemu-trivial@nongnu.org
    Fixes: 0657c657
    Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
    Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
Loading