Skip to content
  • Dongli Zhang's avatar
    aba0d042
    vhost-scsi: fix memleak of vsc->inflight · aba0d042
    Dongli Zhang authored
    
    
    This is below memleak detected when to quit the qemu-system-x86_64 (with
    vhost-scsi-pci).
    
    (qemu) quit
    
    =================================================================
    ==15568==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 40 byte(s) in 1 object(s) allocated from:
        #0 0x7f00aec57917 in __interceptor_calloc (/lib64/libasan.so.6+0xb4917)
        #1 0x7f00ada0d7b5 in g_malloc0 (/lib64/libglib-2.0.so.0+0x517b5)
        #2 0x5648ffd38bac in vhost_scsi_start ../hw/scsi/vhost-scsi.c:92
        #3 0x5648ffd38d52 in vhost_scsi_set_status ../hw/scsi/vhost-scsi.c:131
        #4 0x5648ffda340e in virtio_set_status ../hw/virtio/virtio.c:2036
        #5 0x5648ff8de281 in virtio_ioport_write ../hw/virtio/virtio-pci.c:431
        #6 0x5648ff8deb29 in virtio_pci_config_write ../hw/virtio/virtio-pci.c:576
        #7 0x5648ffe5c0c2 in memory_region_write_accessor ../softmmu/memory.c:493
        #8 0x5648ffe5c424 in access_with_adjusted_size ../softmmu/memory.c:555
        #9 0x5648ffe6428f in memory_region_dispatch_write ../softmmu/memory.c:1515
        #10 0x5648ffe8613d in flatview_write_continue ../softmmu/physmem.c:2825
        #11 0x5648ffe86490 in flatview_write ../softmmu/physmem.c:2867
        #12 0x5648ffe86d9f in address_space_write ../softmmu/physmem.c:2963
        #13 0x5648ffe86e57 in address_space_rw ../softmmu/physmem.c:2973
        #14 0x5648fffbfb3d in kvm_handle_io ../accel/kvm/kvm-all.c:2639
        #15 0x5648fffc0e0d in kvm_cpu_exec ../accel/kvm/kvm-all.c:2890
        #16 0x5648fffc90a7 in kvm_vcpu_thread_fn ../accel/kvm/kvm-accel-ops.c:51
        #17 0x56490042400a in qemu_thread_start ../util/qemu-thread-posix.c:505
        #18 0x7f00ac3b6ea4 in start_thread (/lib64/libpthread.so.0+0x7ea4)
    
    Free the vsc->inflight at the 'stop' path.
    
    Fixes: b82526c7 ("vhost-scsi: support inflight io track")
    Cc: Joe Jin <joe.jin@oracle.com>
    Cc: Li Feng <fengli@smartx.com>
    Signed-off-by: default avatarDongli Zhang <dongli.zhang@oracle.com>
    Message-Id: <20230104160433.21353-1-dongli.zhang@oracle.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    aba0d042
    vhost-scsi: fix memleak of vsc->inflight
    Dongli Zhang authored
    
    
    This is below memleak detected when to quit the qemu-system-x86_64 (with
    vhost-scsi-pci).
    
    (qemu) quit
    
    =================================================================
    ==15568==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 40 byte(s) in 1 object(s) allocated from:
        #0 0x7f00aec57917 in __interceptor_calloc (/lib64/libasan.so.6+0xb4917)
        #1 0x7f00ada0d7b5 in g_malloc0 (/lib64/libglib-2.0.so.0+0x517b5)
        #2 0x5648ffd38bac in vhost_scsi_start ../hw/scsi/vhost-scsi.c:92
        #3 0x5648ffd38d52 in vhost_scsi_set_status ../hw/scsi/vhost-scsi.c:131
        #4 0x5648ffda340e in virtio_set_status ../hw/virtio/virtio.c:2036
        #5 0x5648ff8de281 in virtio_ioport_write ../hw/virtio/virtio-pci.c:431
        #6 0x5648ff8deb29 in virtio_pci_config_write ../hw/virtio/virtio-pci.c:576
        #7 0x5648ffe5c0c2 in memory_region_write_accessor ../softmmu/memory.c:493
        #8 0x5648ffe5c424 in access_with_adjusted_size ../softmmu/memory.c:555
        #9 0x5648ffe6428f in memory_region_dispatch_write ../softmmu/memory.c:1515
        #10 0x5648ffe8613d in flatview_write_continue ../softmmu/physmem.c:2825
        #11 0x5648ffe86490 in flatview_write ../softmmu/physmem.c:2867
        #12 0x5648ffe86d9f in address_space_write ../softmmu/physmem.c:2963
        #13 0x5648ffe86e57 in address_space_rw ../softmmu/physmem.c:2973
        #14 0x5648fffbfb3d in kvm_handle_io ../accel/kvm/kvm-all.c:2639
        #15 0x5648fffc0e0d in kvm_cpu_exec ../accel/kvm/kvm-all.c:2890
        #16 0x5648fffc90a7 in kvm_vcpu_thread_fn ../accel/kvm/kvm-accel-ops.c:51
        #17 0x56490042400a in qemu_thread_start ../util/qemu-thread-posix.c:505
        #18 0x7f00ac3b6ea4 in start_thread (/lib64/libpthread.so.0+0x7ea4)
    
    Free the vsc->inflight at the 'stop' path.
    
    Fixes: b82526c7 ("vhost-scsi: support inflight io track")
    Cc: Joe Jin <joe.jin@oracle.com>
    Cc: Li Feng <fengli@smartx.com>
    Signed-off-by: default avatarDongli Zhang <dongli.zhang@oracle.com>
    Message-Id: <20230104160433.21353-1-dongli.zhang@oracle.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Loading