Skip to content
  • Peter Maydell's avatar
    4a5fc890
    scsi: Use device_cold_reset() and bus_cold_reset() · 4a5fc890
    Peter Maydell authored
    
    
    In the SCSI subsystem we currently use the legacy functions
    qdev_reset_all() and qbus_reset_all().  These perform a recursive
    reset, starting from either a qbus or a qdev.  However they do not
    permit any of the devices in the tree to use three-phase reset,
    because device reset goes through the device_legacy_reset() function
    that only calls the single DeviceClass::reset method.
    
    Switch to using the device_cold_reset() and bus_cold_reset()
    functions.  These also perform a recursive reset, where first the
    children are reset and then finally the parent, but they use the new
    (...in 2020...) Resettable mechanism, which supports both the old
    style single-reset method and also the new 3-phase reset handling.
    
    Since no devices attached to SCSI buses currently try to use 3-phase
    reset, this should be a no-behaviour-change commit which just reduces
    the use of a deprecated API.
    
    Commit created with:
      sed -i -e 's/qdev_reset_all/device_cold_reset/g;s/qbus_reset_all/bus_cold_reset/g' hw/scsi/*.c
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Message-Id: <20221013160623.1296109-2-peter.maydell@linaro.org>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    4a5fc890
    scsi: Use device_cold_reset() and bus_cold_reset()
    Peter Maydell authored
    
    
    In the SCSI subsystem we currently use the legacy functions
    qdev_reset_all() and qbus_reset_all().  These perform a recursive
    reset, starting from either a qbus or a qdev.  However they do not
    permit any of the devices in the tree to use three-phase reset,
    because device reset goes through the device_legacy_reset() function
    that only calls the single DeviceClass::reset method.
    
    Switch to using the device_cold_reset() and bus_cold_reset()
    functions.  These also perform a recursive reset, where first the
    children are reset and then finally the parent, but they use the new
    (...in 2020...) Resettable mechanism, which supports both the old
    style single-reset method and also the new 3-phase reset handling.
    
    Since no devices attached to SCSI buses currently try to use 3-phase
    reset, this should be a no-behaviour-change commit which just reduces
    the use of a deprecated API.
    
    Commit created with:
      sed -i -e 's/qdev_reset_all/device_cold_reset/g;s/qbus_reset_all/bus_cold_reset/g' hw/scsi/*.c
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Message-Id: <20221013160623.1296109-2-peter.maydell@linaro.org>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Loading