Skip to content
  • Eric Blake's avatar
    2e6fc7eb
    block: Rename raw_bsd to raw-format.c · 2e6fc7eb
    Eric Blake authored
    
    
    Given that we have raw-win32.c and raw-posix.c, my initial guess at
    raw_bsd.c was that it was for dealing with raw files using code
    specific to the BSD operating system (beyond what raw-posix could
    do).  Not so - this name was chosen back in commit e1c66c6d to
    distinguish that it was a BSD licensed file, in contrast to the
    then-existing raw.c with an unclear and potentially unusable
    license.  But since it has been more than three years since the
    rewrite, it's time to pick a more useful name for this file to
    avoid this type of confusion to future contributors that don't know
    the backstory, as none of our other files are named solely by the
    license they use.
    
    In reality, this file deals with the raw format, which is useful
    with any number of protocols, while raw-{win32,posix} deal with
    the file protocol (and in turn, that protocol is not limited to
    use with the raw format).  So rename raw_bsd to raw-format.c.  We
    could have also used the shorter name raw.c, except that collides
    with the earlier use of that filename for a different license,
    and it's better to be safe than risk license pollution.
    
    The next patch will also rename raw-win32.c and raw-posix.c to
    further distinguish the difference in roles.
    
    It doesn't hurt that this gets rid of an underscore in the filename,
    thereby making tab-completion on 'ra<TAB>' easier (now I don't have
    to type the shift key, which slows things down :)
    
    Suggested-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    2e6fc7eb
    block: Rename raw_bsd to raw-format.c
    Eric Blake authored
    
    
    Given that we have raw-win32.c and raw-posix.c, my initial guess at
    raw_bsd.c was that it was for dealing with raw files using code
    specific to the BSD operating system (beyond what raw-posix could
    do).  Not so - this name was chosen back in commit e1c66c6d to
    distinguish that it was a BSD licensed file, in contrast to the
    then-existing raw.c with an unclear and potentially unusable
    license.  But since it has been more than three years since the
    rewrite, it's time to pick a more useful name for this file to
    avoid this type of confusion to future contributors that don't know
    the backstory, as none of our other files are named solely by the
    license they use.
    
    In reality, this file deals with the raw format, which is useful
    with any number of protocols, while raw-{win32,posix} deal with
    the file protocol (and in turn, that protocol is not limited to
    use with the raw format).  So rename raw_bsd to raw-format.c.  We
    could have also used the shorter name raw.c, except that collides
    with the earlier use of that filename for a different license,
    and it's better to be safe than risk license pollution.
    
    The next patch will also rename raw-win32.c and raw-posix.c to
    further distinguish the difference in roles.
    
    It doesn't hurt that this gets rid of an underscore in the filename,
    thereby making tab-completion on 'ra<TAB>' easier (now I don't have
    to type the shift key, which slows things down :)
    
    Suggested-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading