Skip to content
  • Vivek Goyal's avatar
    26ec1909
    virtiofsd: Do not use a thread pool by default · 26ec1909
    Vivek Goyal authored
    
    
    Currently we created a thread pool (With 64 max threads per pool) for
    each virtqueue. We hoped that this will provide us with better scalability
    and performance.
    
    But in practice, we are getting better numbers in most of the cases
    when we don't create a thread pool at all and a single thread per
    virtqueue receives the request and processes it.
    
    Hence, I am proposing that we switch to no thread pool by default
    (equivalent of --thread-pool-size=0). This will provide out of
    box better performance to most of the users. In fact other users
    have confirmed that not using a thread pool gives them better
    numbers. So why not use this as default. It can be changed when
    somebody can fix the issues with thread pool performance.
    
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Message-Id: <20210210182744.27324-2-vgoyal@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    26ec1909
    virtiofsd: Do not use a thread pool by default
    Vivek Goyal authored
    
    
    Currently we created a thread pool (With 64 max threads per pool) for
    each virtqueue. We hoped that this will provide us with better scalability
    and performance.
    
    But in practice, we are getting better numbers in most of the cases
    when we don't create a thread pool at all and a single thread per
    virtqueue receives the request and processes it.
    
    Hence, I am proposing that we switch to no thread pool by default
    (equivalent of --thread-pool-size=0). This will provide out of
    box better performance to most of the users. In fact other users
    have confirmed that not using a thread pool gives them better
    numbers. So why not use this as default. It can be changed when
    somebody can fix the issues with thread pool performance.
    
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Message-Id: <20210210182744.27324-2-vgoyal@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Loading