Skip to content
  • Yu-Chen Lin's avatar
    26c9296c
    vmdk: false positive of compat6 with hwversion not set · 26c9296c
    Yu-Chen Lin authored
    
    
    In vmdk_co_create_opts, when it finds hw_version is undefined, it will
    set it to 4, which misleading the compat6 and hwversion in
    vmdk_co_do_create. Simply set hw_version to NULL after free, let
    the logic in vmdk_co_do_create to decide the value of hw_version.
    
    This bug can be reproduced by:
    
    $ qemu-img convert -O vmdk -o subformat=streamOptimized,compat6
    /home/yuchenlin/syno.qcow2 /home/yuchenlin/syno.vmdk
    
    qemu-img: /home/yuchenlin/syno.vmdk: error while converting vmdk:
    compat6 cannot be enabled with hwversion set
    
    Signed-off-by: default avataryuchenlin <yuchenlin@synology.com>
    Message-id: 20190221110805.28239-1-yuchenlin@synology.com
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    26c9296c
    vmdk: false positive of compat6 with hwversion not set
    Yu-Chen Lin authored
    
    
    In vmdk_co_create_opts, when it finds hw_version is undefined, it will
    set it to 4, which misleading the compat6 and hwversion in
    vmdk_co_do_create. Simply set hw_version to NULL after free, let
    the logic in vmdk_co_do_create to decide the value of hw_version.
    
    This bug can be reproduced by:
    
    $ qemu-img convert -O vmdk -o subformat=streamOptimized,compat6
    /home/yuchenlin/syno.qcow2 /home/yuchenlin/syno.vmdk
    
    qemu-img: /home/yuchenlin/syno.vmdk: error while converting vmdk:
    compat6 cannot be enabled with hwversion set
    
    Signed-off-by: default avataryuchenlin <yuchenlin@synology.com>
    Message-id: 20190221110805.28239-1-yuchenlin@synology.com
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading