Skip to content
  • Greg Kurz's avatar
    24f3902b
    savevm: fail if migration blockers are present · 24f3902b
    Greg Kurz authored
    
    
    QEMU has currently two ways to prevent migration to occur:
    - migration blocker when it depends on runtime state
    - VMStateDescription.unmigratable when migration is not supported at all
    
    This patch gathers all the logic into a single function to be called from
    both the savevm and the migrate paths.
    
    This fixes a bug with 9p, at least, where savevm would succeed and the
    following would happen in the guest after loadvm:
    
    $ ls /host
    ls: cannot access /host: Protocol error
    
    With this patch:
    
    (qemu) savevm foo
    Migration is disabled when VirtFS export path '/' is mounted in the guest
    using mount_tag 'host'
    
    Signed-off-by: default avatarGreg Kurz <gkurz@linux.vnet.ibm.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <146239057139.11271.9011797645454781543.stgit@bahia.huguette.org>
    
    [Update subject according to Paolo's suggestion - Amit]
    
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
    24f3902b
    savevm: fail if migration blockers are present
    Greg Kurz authored
    
    
    QEMU has currently two ways to prevent migration to occur:
    - migration blocker when it depends on runtime state
    - VMStateDescription.unmigratable when migration is not supported at all
    
    This patch gathers all the logic into a single function to be called from
    both the savevm and the migrate paths.
    
    This fixes a bug with 9p, at least, where savevm would succeed and the
    following would happen in the guest after loadvm:
    
    $ ls /host
    ls: cannot access /host: Protocol error
    
    With this patch:
    
    (qemu) savevm foo
    Migration is disabled when VirtFS export path '/' is mounted in the guest
    using mount_tag 'host'
    
    Signed-off-by: default avatarGreg Kurz <gkurz@linux.vnet.ibm.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <146239057139.11271.9011797645454781543.stgit@bahia.huguette.org>
    
    [Update subject according to Paolo's suggestion - Amit]
    
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Loading