Skip to content
  • Daniel Xu's avatar
    810f677a
    qga: Add `merged` variant to GuestExecCaptureOutputMode · 810f677a
    Daniel Xu authored
    
    
    Currently, any captured output (via `capture-output`) is segregated into
    separate GuestExecStatus fields (`out-data` and `err-data`). This means
    that downstream consumers have no way to reassemble the captured data
    back into the original stream.
    
    This is relevant for chatty and semi-interactive (ie. read only) CLI
    tools.  Such tools may deliberately interleave stdout and stderr for
    visual effect. If segregated, the output becomes harder to visually
    understand.
    
    This commit adds a new enum variant to the GuestExecCaptureOutputMode
    qapi to merge the output streams such that consumers can have a pristine
    view of the original command output.
    
    Signed-off-by: default avatarDaniel Xu <dxu@dxuuu.xyz>
    Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: default avatarKonstantin Kostiuk <kkostiuk@redhat.com>
    810f677a
    qga: Add `merged` variant to GuestExecCaptureOutputMode
    Daniel Xu authored
    
    
    Currently, any captured output (via `capture-output`) is segregated into
    separate GuestExecStatus fields (`out-data` and `err-data`). This means
    that downstream consumers have no way to reassemble the captured data
    back into the original stream.
    
    This is relevant for chatty and semi-interactive (ie. read only) CLI
    tools.  Such tools may deliberately interleave stdout and stderr for
    visual effect. If segregated, the output becomes harder to visually
    understand.
    
    This commit adds a new enum variant to the GuestExecCaptureOutputMode
    qapi to merge the output streams such that consumers can have a pristine
    view of the original command output.
    
    Signed-off-by: default avatarDaniel Xu <dxu@dxuuu.xyz>
    Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: default avatarKonstantin Kostiuk <kkostiuk@redhat.com>
Loading