Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    d003e0ae
    block: rename backup-top to copy-before-write · d003e0ae
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are going to convert backup_top to full featured public filter,
    which can be used in separate of backup job. Start from renaming from
    "how it used" to "what it does".
    
    While updating comments in 283 iotest, drop and rephrase also things
    about ".active", as this field is now dropped, and filter doesn't have
    "inactive" mode.
    
    Note that this change may be considered as incompatible interface
    change, as backup-top filter format name was visible through
    query-block and query-named-block-nodes.
    
    Still, consider the following reasoning:
    
    1. backup-top was never documented, so if someone depends on format
       name (for driver that can't be used other than it is automatically
       inserted on backup job start), it's a kind of "undocumented feature
       use". So I think we are free to change it.
    
    2. There is a hope, that there is no such users: it's a lot more native
       to give a good node-name to backup-top filter if need to operate
       with it somehow, and don't touch format name.
    
    3. Another "incompatible" change in further commit would be moving
       copy-before-write filter from using backing child to file child. And
       this is even more reasonable than renaming: for now all public
       filters are file-child based.
    
    So, it's a risky change, but risk seems small and good interface worth
    it.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20210824083856.17408-6-vsementsov@virtuozzo.com>
    Signed-off-by: default avatarHanna Reitz <hreitz@redhat.com>
    d003e0ae
    block: rename backup-top to copy-before-write
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are going to convert backup_top to full featured public filter,
    which can be used in separate of backup job. Start from renaming from
    "how it used" to "what it does".
    
    While updating comments in 283 iotest, drop and rephrase also things
    about ".active", as this field is now dropped, and filter doesn't have
    "inactive" mode.
    
    Note that this change may be considered as incompatible interface
    change, as backup-top filter format name was visible through
    query-block and query-named-block-nodes.
    
    Still, consider the following reasoning:
    
    1. backup-top was never documented, so if someone depends on format
       name (for driver that can't be used other than it is automatically
       inserted on backup job start), it's a kind of "undocumented feature
       use". So I think we are free to change it.
    
    2. There is a hope, that there is no such users: it's a lot more native
       to give a good node-name to backup-top filter if need to operate
       with it somehow, and don't touch format name.
    
    3. Another "incompatible" change in further commit would be moving
       copy-before-write filter from using backing child to file child. And
       this is even more reasonable than renaming: for now all public
       filters are file-child based.
    
    So, it's a risky change, but risk seems small and good interface worth
    it.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-Id: <20210824083856.17408-6-vsementsov@virtuozzo.com>
    Signed-off-by: default avatarHanna Reitz <hreitz@redhat.com>
Loading