Skip to content
  • Markus Armbruster's avatar
    1bda8b3c
    migration: Unshare MigrationParameters struct for now · 1bda8b3c
    Markus Armbruster authored
    
    
    Commit de63ab61 "migrate: Share common MigrationParameters struct"
    reused MigrationParameters for the arguments of
    migrate-set-parameters, with the following rationale:
    
        It is rather verbose, and slightly error-prone, to repeat
        the same set of parameters for input (migrate-set-parameters)
        as for output (query-migrate-parameters), where the only
        difference is whether the members are optional.  We can just
        document that the optional members will always be present
        on output, and then share a common struct between both
        commands.  The next patch can then reduce the amount of
        code needed on input.
    
    I need to unshare them to correct a design flaw in a stupid, but
    minimally invasive way, in the next commit.  We can restore the
    sharing when we redo that patch in a less stupid way.  Add a suitable
    TODO comment.
    
    Note that I revert only the sharing part of commit de63ab61, not the
    part that made the members of query-migrate-parameters' result
    optional.  The schema (and thus introspection) remains inaccurate for
    query-migrate-parameters.  If we decide not to restore the sharing, we
    should revert that part, too.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    1bda8b3c
    migration: Unshare MigrationParameters struct for now
    Markus Armbruster authored
    
    
    Commit de63ab61 "migrate: Share common MigrationParameters struct"
    reused MigrationParameters for the arguments of
    migrate-set-parameters, with the following rationale:
    
        It is rather verbose, and slightly error-prone, to repeat
        the same set of parameters for input (migrate-set-parameters)
        as for output (query-migrate-parameters), where the only
        difference is whether the members are optional.  We can just
        document that the optional members will always be present
        on output, and then share a common struct between both
        commands.  The next patch can then reduce the amount of
        code needed on input.
    
    I need to unshare them to correct a design flaw in a stupid, but
    minimally invasive way, in the next commit.  We can restore the
    sharing when we redo that patch in a less stupid way.  Add a suitable
    TODO comment.
    
    Note that I revert only the sharing part of commit de63ab61, not the
    part that made the members of query-migrate-parameters' result
    optional.  The schema (and thus introspection) remains inaccurate for
    query-migrate-parameters.  If we decide not to restore the sharing, we
    should revert that part, too.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Loading