Skip to content
  • David Hildenbrand's avatar
    1a373522
    migrate/ram: remove "ram_bulk_stage" and "fpo_enabled" · 1a373522
    David Hildenbrand authored
    
    
    The bulk stage is kind of weird: migration_bitmap_find_dirty() will
    indicate a dirty page, however, ram_save_host_page() will never save it, as
    migration_bitmap_clear_dirty() detects that it is not dirty.
    
    We already fill the bitmap in ram_list_init_bitmaps() with ones, marking
    everything dirty - it didn't used to be that way, which is why we needed
    an explicit first bulk stage.
    
    Let's simplify: make the bitmap the single source of thuth. Explicitly
    handle the "xbzrle_enabled after first round" case.
    
    Regarding XBZRLE (implicitly handled via "ram_bulk_stage = false" right
    now), there is now a slight change in behavior:
    - Colo: When starting, it will be disabled (was implicitly enabled)
      until the first round actually finishes.
    - Free page hinting: When starting, XBZRLE will be disabled (was implicitly
      enabled) until the first round actually finished.
    - Snapshots: When starting, XBZRLE will be disabled. We essentially only
      do a single run, so I guess it will never actually get disabled.
    
    Postcopy seems to indirectly disable it in ram_save_page(), so there
    shouldn't be really any change.
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Juan Quintela <quintela@redhat.com>
    Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
    Cc: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
    Cc: Peter Xu <peterx@redhat.com>
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Message-Id: <20210216105039.40680-1-david@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    1a373522
    migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"
    David Hildenbrand authored
    
    
    The bulk stage is kind of weird: migration_bitmap_find_dirty() will
    indicate a dirty page, however, ram_save_host_page() will never save it, as
    migration_bitmap_clear_dirty() detects that it is not dirty.
    
    We already fill the bitmap in ram_list_init_bitmaps() with ones, marking
    everything dirty - it didn't used to be that way, which is why we needed
    an explicit first bulk stage.
    
    Let's simplify: make the bitmap the single source of thuth. Explicitly
    handle the "xbzrle_enabled after first round" case.
    
    Regarding XBZRLE (implicitly handled via "ram_bulk_stage = false" right
    now), there is now a slight change in behavior:
    - Colo: When starting, it will be disabled (was implicitly enabled)
      until the first round actually finishes.
    - Free page hinting: When starting, XBZRLE will be disabled (was implicitly
      enabled) until the first round actually finished.
    - Snapshots: When starting, XBZRLE will be disabled. We essentially only
      do a single run, so I guess it will never actually get disabled.
    
    Postcopy seems to indirectly disable it in ram_save_page(), so there
    shouldn't be really any change.
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Juan Quintela <quintela@redhat.com>
    Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
    Cc: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
    Cc: Peter Xu <peterx@redhat.com>
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Message-Id: <20210216105039.40680-1-david@redhat.com>
    Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Loading