Skip to content
  • Zhao Liu's avatar
    196ea60a
    hw/smbios: Fix core count in type4 · 196ea60a
    Zhao Liu authored
    
    
    >From SMBIOS 3.0 specification, core count field means:
    
    Core Count is the number of cores detected by the BIOS for this
    processor socket. [1]
    
    Before 003f230e ("machine: Tweak the order of topology members in
    struct CpuTopology"), MachineState.smp.cores means "the number of cores
    in one package", and it's correct to use smp.cores for core count.
    
    But 003f230e changes the smp.cores' meaning to "the number of cores
    in one die" and doesn't change the original smp.cores' use in smbios as
    well, which makes core count in type4 go wrong.
    
    Fix this issue with the correct "cores per socket" caculation.
    
    [1] SMBIOS 3.0.0, section 7.5.6, Processor Information - Core Count
    
    Fixes: 003f230e ("machine: Tweak the order of topology members in struct CpuTopology")
    Signed-off-by: default avatarZhao Liu <zhao1.liu@intel.com>
    Message-Id: <20230628135437.1145805-5-zhao1.liu@linux.intel.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    196ea60a
    hw/smbios: Fix core count in type4
    Zhao Liu authored
    
    
    >From SMBIOS 3.0 specification, core count field means:
    
    Core Count is the number of cores detected by the BIOS for this
    processor socket. [1]
    
    Before 003f230e ("machine: Tweak the order of topology members in
    struct CpuTopology"), MachineState.smp.cores means "the number of cores
    in one package", and it's correct to use smp.cores for core count.
    
    But 003f230e changes the smp.cores' meaning to "the number of cores
    in one die" and doesn't change the original smp.cores' use in smbios as
    well, which makes core count in type4 go wrong.
    
    Fix this issue with the correct "cores per socket" caculation.
    
    [1] SMBIOS 3.0.0, section 7.5.6, Processor Information - Core Count
    
    Fixes: 003f230e ("machine: Tweak the order of topology members in struct CpuTopology")
    Signed-off-by: default avatarZhao Liu <zhao1.liu@intel.com>
    Message-Id: <20230628135437.1145805-5-zhao1.liu@linux.intel.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Loading