Skip to content
  • Kevin Wolf's avatar
    bde70715
    commit: Remove overlay_bs · bde70715
    Kevin Wolf authored
    
    
    We don't need to make any assumptions about the graph layout above the
    top node of the commit operation any more. Remove the use of
    bdrv_find_overlay() and related variables from the commit job code.
    
    bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so
    we can just drop it.
    
    The overlay node was previously added to the block job to get a
    BLK_PERM_GRAPH_MOD. We really need to respect those permissions in
    bdrv_drop_intermediate() now, but as long as we haven't figured out yet
    how BLK_PERM_GRAPH_MOD is actually supposed to work, just leave a TODO
    comment there.
    
    With this change, it is now possible to perform another block job on an
    overlay node without conflicts. qemu-iotests 030 is changed accordingly.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    bde70715
    commit: Remove overlay_bs
    Kevin Wolf authored
    
    
    We don't need to make any assumptions about the graph layout above the
    top node of the commit operation any more. Remove the use of
    bdrv_find_overlay() and related variables from the commit job code.
    
    bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so
    we can just drop it.
    
    The overlay node was previously added to the block job to get a
    BLK_PERM_GRAPH_MOD. We really need to respect those permissions in
    bdrv_drop_intermediate() now, but as long as we haven't figured out yet
    how BLK_PERM_GRAPH_MOD is actually supposed to work, just leave a TODO
    comment there.
    
    With this change, it is now possible to perform another block job on an
    overlay node without conflicts. qemu-iotests 030 is changed accordingly.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Loading