Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    17abcbee
    block/io: use int64_t bytes in driver wrappers · 17abcbee
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, convert driver wrappers parameters which are already 64bit to
    signed type.
    
    Requests in block/io.c must never exceed BDRV_MAX_LENGTH (which is less
    than INT64_MAX), which makes the conversion to signed 64bit type safe.
    
    Add corresponding assertions.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-10-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    17abcbee
    block/io: use int64_t bytes in driver wrappers
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, convert driver wrappers parameters which are already 64bit to
    signed type.
    
    Requests in block/io.c must never exceed BDRV_MAX_LENGTH (which is less
    than INT64_MAX), which makes the conversion to signed 64bit type safe.
    
    Add corresponding assertions.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-10-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Loading