Skip to content
  • Markus Armbruster's avatar
    90c84c56
    qom/cpu: Simplify how CPUClass:cpu_dump_state() prints · 90c84c56
    Markus Armbruster authored
    
    
    CPUClass method dump_statistics() takes an fprintf()-like callback and
    a FILE * to pass to it.  Most callers pass fprintf() and stderr.
    log_cpu_state() passes fprintf() and qemu_log_file.
    hmp_info_registers() passes monitor_fprintf() and the current monitor
    cast to FILE *.  monitor_fprintf() casts it right back, and is
    otherwise identical to monitor_printf().
    
    The callback gets passed around a lot, which is tiresome.  The
    type-punning around monitor_fprintf() is ugly.
    
    Drop the callback, and call qemu_fprintf() instead.  Also gets rid of
    the type-punning, since qemu_fprintf() takes NULL instead of the
    current monitor cast to FILE *.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Message-Id: <20190417191805.28198-15-armbru@redhat.com>
    90c84c56
    qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
    Markus Armbruster authored
    
    
    CPUClass method dump_statistics() takes an fprintf()-like callback and
    a FILE * to pass to it.  Most callers pass fprintf() and stderr.
    log_cpu_state() passes fprintf() and qemu_log_file.
    hmp_info_registers() passes monitor_fprintf() and the current monitor
    cast to FILE *.  monitor_fprintf() casts it right back, and is
    otherwise identical to monitor_printf().
    
    The callback gets passed around a lot, which is tiresome.  The
    type-punning around monitor_fprintf() is ugly.
    
    Drop the callback, and call qemu_fprintf() instead.  Also gets rid of
    the type-punning, since qemu_fprintf() takes NULL instead of the
    current monitor cast to FILE *.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Message-Id: <20190417191805.28198-15-armbru@redhat.com>
Loading