Skip to content
  • Hanna Reitz's avatar
    ceaca56f
    block: Add bdrv_has_zero_init_truncate() · ceaca56f
    Hanna Reitz authored
    
    
    No .bdrv_has_zero_init() implementation returns 1 if growing the file
    would add non-zero areas (at least with PREALLOC_MODE_OFF), so using it
    in lieu of this new function was always safe.
    
    But on the other hand, it is possible that growing an image that is not
    zero-initialized would still add a zero-initialized area, like when
    using nonpreallocating truncation on a preallocated image.  For callers
    that care only about truncation, not about creation with potential
    preallocation, this new function is useful.
    
    Alternatively, we could have added a PreallocMode parameter to
    bdrv_has_zero_init().  But the only user would have been qemu-img
    convert, which does not have a plain PreallocMode value right now -- it
    would have to parse the creation option to obtain it.  Therefore, the
    simpler solution is to let bdrv_has_zero_init() inquire the
    preallocation status and add the new bdrv_has_zero_init_truncate() that
    presupposes PREALLOC_MODE_OFF.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20190724171239.8764-4-mreitz@redhat.com
    Reviewed-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    ceaca56f
    block: Add bdrv_has_zero_init_truncate()
    Hanna Reitz authored
    
    
    No .bdrv_has_zero_init() implementation returns 1 if growing the file
    would add non-zero areas (at least with PREALLOC_MODE_OFF), so using it
    in lieu of this new function was always safe.
    
    But on the other hand, it is possible that growing an image that is not
    zero-initialized would still add a zero-initialized area, like when
    using nonpreallocating truncation on a preallocated image.  For callers
    that care only about truncation, not about creation with potential
    preallocation, this new function is useful.
    
    Alternatively, we could have added a PreallocMode parameter to
    bdrv_has_zero_init().  But the only user would have been qemu-img
    convert, which does not have a plain PreallocMode value right now -- it
    would have to parse the creation option to obtain it.  Therefore, the
    simpler solution is to let bdrv_has_zero_init() inquire the
    preallocation status and add the new bdrv_has_zero_init_truncate() that
    presupposes PREALLOC_MODE_OFF.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20190724171239.8764-4-mreitz@redhat.com
    Reviewed-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading