Skip to content
  • Eric Blake's avatar
    0b2a0d6b
    qapi: Swap 'name' in visit_* callbacks to match public API · 0b2a0d6b
    Eric Blake authored
    
    
    As explained in the previous patches, matching argument order of
    'name, &value' to JSON's "name":value makes sense.  However,
    while the last two patches were easy with Coccinelle, I ended up
    doing this one all by hand.  Now all the visitor callbacks match
    the main interface.
    
    The compiler is able to enforce that all clients match the changed
    interface in visitor-impl.h, even where two pointers are being
    swapped, because only one of the two pointers is const (if that
    were not the case, then C's looseness on treating 'char *' like
    'void *' would have made review a bit harder).
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1454075341-13658-21-git-send-email-eblake@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    0b2a0d6b
    qapi: Swap 'name' in visit_* callbacks to match public API
    Eric Blake authored
    
    
    As explained in the previous patches, matching argument order of
    'name, &value' to JSON's "name":value makes sense.  However,
    while the last two patches were easy with Coccinelle, I ended up
    doing this one all by hand.  Now all the visitor callbacks match
    the main interface.
    
    The compiler is able to enforce that all clients match the changed
    interface in visitor-impl.h, even where two pointers are being
    swapped, because only one of the two pointers is const (if that
    were not the case, then C's looseness on treating 'char *' like
    'void *' would have made review a bit harder).
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1454075341-13658-21-git-send-email-eblake@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Loading