Skip to content
  • Markus Armbruster's avatar
    093e3679
    Revert "qapi-events: add 'if' condition to implicit event enum" · 093e3679
    Markus Armbruster authored
    
    
    This reverts commit 7bd26349.
    
    The commit applied the events' conditions to the members of enum
    QAPIEvent.  Awkward, because it renders QAPIEvent unusable in
    target-independent code as soon as we make an event target-dependent.
    Reverting this has the following effects:
    
    * ui/vnc.c can remain target independent.
    
    * monitor_qapi_event_conf[] doesn't have to muck around with #ifdef.
    
    * query-events again doesn't reflect conditionals.  I'm going to
      deprecate it in favor of query-qmp-schema.
    
    Another option would be to split target-dependent parts off enum
    QAPIEvent into a target-dependent enum.  Doesn't seem worthwhile right
    now.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20190214152251.2073-17-armbru@redhat.com>
    093e3679
    Revert "qapi-events: add 'if' condition to implicit event enum"
    Markus Armbruster authored
    
    
    This reverts commit 7bd26349.
    
    The commit applied the events' conditions to the members of enum
    QAPIEvent.  Awkward, because it renders QAPIEvent unusable in
    target-independent code as soon as we make an event target-dependent.
    Reverting this has the following effects:
    
    * ui/vnc.c can remain target independent.
    
    * monitor_qapi_event_conf[] doesn't have to muck around with #ifdef.
    
    * query-events again doesn't reflect conditionals.  I'm going to
      deprecate it in favor of query-qmp-schema.
    
    Another option would be to split target-dependent parts off enum
    QAPIEvent into a target-dependent enum.  Doesn't seem worthwhile right
    now.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20190214152251.2073-17-armbru@redhat.com>
Loading