Skip to content
  • Markus Armbruster's avatar
    238e9202
    qapi transaction: Elide redundant has_FOO in generated C · 238e9202
    Markus Armbruster authored
    
    
    The has_FOO for pointer-valued FOO are redundant, except for arrays.
    They are also a nuisance to work with.  Recent commit "qapi: Start to
    elide redundant has_FOO in generated C" provided the means to elide
    them step by step.  This is the step for qapi/transaction.json.
    
    Said commit explains the transformation in more detail.  The invariant
    violations mentioned there do not occur here.
    
    In qmp_transaction(), we can't just drop parameter @has_props, since
    it's used to track whether @props needs to be freed.  Replace it by a
    local variable.
    
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Hanna Reitz <hreitz@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20221104160712.3005652-27-armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    238e9202
    qapi transaction: Elide redundant has_FOO in generated C
    Markus Armbruster authored
    
    
    The has_FOO for pointer-valued FOO are redundant, except for arrays.
    They are also a nuisance to work with.  Recent commit "qapi: Start to
    elide redundant has_FOO in generated C" provided the means to elide
    them step by step.  This is the step for qapi/transaction.json.
    
    Said commit explains the transformation in more detail.  The invariant
    violations mentioned there do not occur here.
    
    In qmp_transaction(), we can't just drop parameter @has_props, since
    it's used to track whether @props needs to be freed.  Replace it by a
    local variable.
    
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Hanna Reitz <hreitz@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20221104160712.3005652-27-armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
Loading